MessageTray: remove all tweens when tweening for state parameters

MessageTray._tween sets the state variable to the in-progress value,
so it must be sure that at the end of the animation the value will
be the corresponding final and nothing else will happen in between.

https://bugzilla.gnome.org/show_bug.cgi?id=683986

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 061135ae78fd9267319d959c4c39484460a66a0c..0241dbdc3919d94e975823e1f978537f24586bd0 100644 (file)
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -2108,6 +2108,8 @@ const MessageTray = new Lang.Class({
         params.onCompleteScope = this;
         params.onCompleteParams = [statevar, value, onComplete, onCompleteScope, onCompleteParams];
 
+        // Remove other tweens that could mess with the state machine
+        Tweener.removeTweens(actor);
         Tweener.addTween(actor, params);
 
         let valuing = (value == State.SHOWN) ? State.SHOWING : State.HIDING;
@@ -2429,8 +2431,6 @@ const MessageTray = new Lang.Class({
         if (this._notificationWidget.y < expandedY) {
             this._notificationWidget.y = expandedY;
         } else if (this._notification.y != expandedY) {
-            // Remove any other tween that could mess with the state machine
-            Tweener.removeTweens(this._notificationWidget);
             // Tween also opacity here, to override a possible tween that's
             // currently hiding the notification.
             this._tween(this._notificationWidget, '_notificationState', State.SHOWN,